2011-10-01 12 views
27

Ho un database con 4 colonne:SQLite Aggiungi colonna, mantenere i dati

@Override 
public void onCreate(SQLiteDatabase database) { 
     database.execSQL("CREATE TABLE " + DATABASENAME + " (name TEXT, latitude REAL, longitude REAL, country TEXT);"); 
} 

Ora voglio aggiungere un'altra colonna, ma mantenere le righe che sono già presenti nel database. Come dovrei farlo? Non riesco a trovare riferimenti utili a questo.

@Override 
public void onUpgrade(SQLiteDatabase db, int arg1, int arg2) { 
    //What to do here? 
} 

EDIT

ho modificato il mio onCreate a:

@Override 
public void onCreate(SQLiteDatabase database) { 
    database.execSQL("CREATE TABLE " + DATABASENAME + " (name TEXT, latitude REAL, longitude REAL, country TEXT, code TEXT);"); 
} 

e la mia ONUPGRADE a:

@Override 
public void onUpgrade(SQLiteDatabase db, int arg1, int arg2) { 
    Logger.log("Updating userstations database from " + arg1 + " to " + arg2 + "."); 
    if (arg1 == 2 && arg2 == 3) { 
     db.execSQL("ALTER TABLE " + DATABASENAME + " ADD COLUMN code TEXT;"); 
    } else if(arg1 == 1){ 
     db.execSQL("DROP TABLE IF EXISTS " + DATABASENAME); 
    } 
    onCreate(db); 
} 

Tuttavia, ora ottengo questo stacktrace:

10-01 21:24:19.581: ERROR/Database(21434): Failure 1 (table userstations already exists) on 0x19c378 when preparing 'CREATE TABLE userstations (name TEXT, latitude REAL, longitude REAL, country TEXT, code TEXT);'. 
10-01 21:24:19.611: ERROR/SQLiteOpenHelper(21434): Couldn't open userstations for writing (will try read-only): 
10-01 21:24:19.611: ERROR/SQLiteOpenHelper(21434): android.database.sqlite.SQLiteException: table userstations already exists: CREATE TABLE userstations (name TEXT, latitude REAL, longitude REAL, country TEXT, code TEXT); 
10-01 21:24:19.611: ERROR/SQLiteOpenHelper(21434):  at android.database.sqlite.SQLiteDatabase.native_execSQL(Native Method) 
10-01 21:24:19.611: ERROR/SQLiteOpenHelper(21434):  at android.database.sqlite.SQLiteDatabase.execSQL(SQLiteDatabase.java:1763) 
10-01 21:24:19.611: ERROR/SQLiteOpenHelper(21434):  at com.myapp.myapp.databases.UserStationsOpenHelper.onCreate(UserStationsOpenHelper.java:25) 
10-01 21:24:19.611: ERROR/SQLiteOpenHelper(21434):  at com.myapp.myapp.databases.UserStationsOpenHelper.onUpgrade(UserStationsOpenHelper.java:36) 
10-01 21:24:19.611: ERROR/SQLiteOpenHelper(21434):  at android.database.sqlite.SQLiteOpenHelper.getWritableDatabase(SQLiteOpenHelper.java:132) 
10-01 21:24:19.611: ERROR/SQLiteOpenHelper(21434):  at android.database.sqlite.SQLiteOpenHelper.getReadableDatabase(SQLiteOpenHelper.java:187) 
10-01 21:24:19.611: ERROR/SQLiteOpenHelper(21434):  at com.myapp.myapp.databases.UserStationsOpenHelper.getStations(UserStationsOpenHelper.java:43) 
10-01 21:24:19.611: ERROR/SQLiteOpenHelper(21434):  at com.myapp.myapp.Data.readUserStations(Data.java:369) 
10-01 21:24:19.611: ERROR/SQLiteOpenHelper(21434):  at com.myapp.myapp.Data.getUserStations(Data.java:210) 
10-01 21:24:19.611: ERROR/SQLiteOpenHelper(21434):  at com.myapp.myapp.stationstab.StationsActivity.newStations(StationsActivity.java:190) 
10-01 21:24:19.611: ERROR/SQLiteOpenHelper(21434):  at com.myapp.myapp.stationstab.StationsActivity.refresh(StationsActivity.java:129) 
10-01 21:24:19.611: ERROR/SQLiteOpenHelper(21434):  at com.myapp.myapp.stationstab.StationsActivity.onCreate(StationsActivity.java:108) 
10-01 21:24:19.611: ERROR/SQLiteOpenHelper(21434):  at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1047) 
10-01 21:24:19.611: ERROR/SQLiteOpenHelper(21434):  at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:1722) 
10-01 21:24:19.611: ERROR/SQLiteOpenHelper(21434):  at android.app.ActivityThread.startActivityNow(ActivityThread.java:1598) 
10-01 21:24:19.611: ERROR/SQLiteOpenHelper(21434):  at android.app.LocalActivityManager.moveToState(LocalActivityManager.java:127) 
10-01 21:24:19.611: ERROR/SQLiteOpenHelper(21434):  at android.app.LocalActivityManager.startActivity(LocalActivityManager.java:339) 
10-01 21:24:19.611: ERROR/SQLiteOpenHelper(21434):  at com.myapp.myapp.stationstab.StationsActivityGroup.onCreate(StationsActivityGroup.java:38) 
10-01 21:24:19.611: ERROR/SQLiteOpenHelper(21434):  at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1047) 
10-01 21:24:19.611: ERROR/SQLiteOpenHelper(21434):  at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:1722) 
10-01 21:24:19.611: ERROR/SQLiteOpenHelper(21434):  at android.app.ActivityThread.startActivityNow(ActivityThread.java:1598) 
10-01 21:24:19.611: ERROR/SQLiteOpenHelper(21434):  at android.app.LocalActivityManager.moveToState(LocalActivityManager.java:127) 
10-01 21:24:19.611: ERROR/SQLiteOpenHelper(21434):  at android.app.LocalActivityManager.startActivity(LocalActivityManager.java:339) 
10-01 21:24:19.611: ERROR/SQLiteOpenHelper(21434):  at android.widget.TabHost$IntentContentStrategy.getContentView(TabHost.java:654) 
10-01 21:24:19.611: ERROR/SQLiteOpenHelper(21434):  at android.widget.TabHost.setCurrentTab(TabHost.java:326) 
10-01 21:24:19.611: ERROR/SQLiteOpenHelper(21434):  at android.widget.TabHost.addTab(TabHost.java:216) 
10-01 21:24:19.611: ERROR/SQLiteOpenHelper(21434):  at com.myapp.myapp.TreinVerkeer.setupTab(TreinVerkeer.java:131) 
10-01 21:24:19.611: ERROR/SQLiteOpenHelper(21434):  at com.myapp.myapp.TreinVerkeer.initTabs(TreinVerkeer.java:108) 
10-01 21:24:19.611: ERROR/SQLiteOpenHelper(21434):  at com.myapp.myapp.TreinVerkeer.onCreate(TreinVerkeer.java:62) 
10-01 21:24:19.611: ERROR/SQLiteOpenHelper(21434):  at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1047) 
10-01 21:24:19.611: ERROR/SQLiteOpenHelper(21434):  at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:1722) 
10-01 21:24:19.611: ERROR/SQLiteOpenHelper(21434):  at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:1784) 
10-01 21:24:19.611: ERROR/SQLiteOpenHelper(21434):  at android.app.ActivityThread.access$1500(ActivityThread.java:123) 
10-01 21:24:19.611: ERROR/SQLiteOpenHelper(21434):  at android.app.ActivityThread$H.handleMessage(ActivityThread.java:939) 
10-01 21:24:19.611: ERROR/SQLiteOpenHelper(21434):  at android.os.Handler.dispatchMessage(Handler.java:99) 
10-01 21:24:19.611: ERROR/SQLiteOpenHelper(21434):  at android.os.Looper.loop(Looper.java:123) 
10-01 21:24:19.611: ERROR/SQLiteOpenHelper(21434):  at android.app.ActivityThread.main(ActivityThread.java:3835) 
10-01 21:24:19.611: ERROR/SQLiteOpenHelper(21434):  at java.lang.reflect.Method.invokeNative(Native Method) 
10-01 21:24:19.611: ERROR/SQLiteOpenHelper(21434):  at java.lang.reflect.Method.invoke(Method.java:507) 
10-01 21:24:19.611: ERROR/SQLiteOpenHelper(21434):  at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:841) 
10-01 21:24:19.611: ERROR/SQLiteOpenHelper(21434):  at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:599) 
10-01 21:24:19.611: ERROR/SQLiteOpenHelper(21434):  at dalvik.system.NativeStart.main(Native Method) 
10-01 21:24:19.621: DEBUG/AndroidRuntime(21434): Shutting down VM 
10-01 21:24:19.621: WARN/dalvikvm(21434): threadid=1: thread exiting with uncaught exception (group=0x4018a560) 
10-01 21:24:19.641: ERROR/AndroidRuntime(21434): FATAL EXCEPTION: main 
10-01 21:24:19.641: ERROR/AndroidRuntime(21434): java.lang.RuntimeException: Unable to start activity ComponentInfo{com.myapp.myapp/com.myapp.myapp.TreinVerkeer}: java.lang.RuntimeException: Unable to start activity ComponentInfo{com.myapp.myapp/com.myapp.myapp.stationstab.StationsActivityGroup}: java.lang.RuntimeException: Unable to start activity ComponentInfo{com.myapp.myapp/com.myapp.myapp.stationstab.StationsActivity}: android.database.sqlite.SQLiteException: Can't upgrade read-only database from version 2 to 3: /data/data/com.myapp.myapp/databases/userstations 
10-01 21:24:19.641: ERROR/AndroidRuntime(21434):  at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:1768) 
10-01 21:24:19.641: ERROR/AndroidRuntime(21434):  at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:1784) 
10-01 21:24:19.641: ERROR/AndroidRuntime(21434):  at android.app.ActivityThread.access$1500(ActivityThread.java:123) 
10-01 21:24:19.641: ERROR/AndroidRuntime(21434):  at android.app.ActivityThread$H.handleMessage(ActivityThread.java:939) 
10-01 21:24:19.641: ERROR/AndroidRuntime(21434):  at android.os.Handler.dispatchMessage(Handler.java:99) 
10-01 21:24:19.641: ERROR/AndroidRuntime(21434):  at android.os.Looper.loop(Looper.java:123) 
10-01 21:24:19.641: ERROR/AndroidRuntime(21434):  at android.app.ActivityThread.main(ActivityThread.java:3835) 
10-01 21:24:19.641: ERROR/AndroidRuntime(21434):  at java.lang.reflect.Method.invokeNative(Native Method) 
10-01 21:24:19.641: ERROR/AndroidRuntime(21434):  at java.lang.reflect.Method.invoke(Method.java:507) 
10-01 21:24:19.641: ERROR/AndroidRuntime(21434):  at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:841) 
10-01 21:24:19.641: ERROR/AndroidRuntime(21434):  at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:599) 
10-01 21:24:19.641: ERROR/AndroidRuntime(21434):  at dalvik.system.NativeStart.main(Native Method) 
10-01 21:24:19.641: ERROR/AndroidRuntime(21434): Caused by: java.lang.RuntimeException: Unable to start activity ComponentInfo{com.myapp.myapp/com.myapp.myapp.stationstab.StationsActivityGroup}: java.lang.RuntimeException: Unable to start activity ComponentInfo{com.myapp.myapp/com.myapp.myapp.stationstab.StationsActivity}: android.database.sqlite.SQLiteException: Can't upgrade read-only database from version 2 to 3: /data/data/com.myapp.myapp/databases/userstations 
10-01 21:24:19.641: ERROR/AndroidRuntime(21434):  at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:1768) 
10-01 21:24:19.641: ERROR/AndroidRuntime(21434):  at android.app.ActivityThread.startActivityNow(ActivityThread.java:1598) 
10-01 21:24:19.641: ERROR/AndroidRuntime(21434):  at android.app.LocalActivityManager.moveToState(LocalActivityManager.java:127) 
10-01 21:24:19.641: ERROR/AndroidRuntime(21434):  at android.app.LocalActivityManager.startActivity(LocalActivityManager.java:339) 
10-01 21:24:19.641: ERROR/AndroidRuntime(21434):  at android.widget.TabHost$IntentContentStrategy.getContentView(TabHost.java:654) 
10-01 21:24:19.641: ERROR/AndroidRuntime(21434):  at android.widget.TabHost.setCurrentTab(TabHost.java:326) 
10-01 21:24:19.641: ERROR/AndroidRuntime(21434):  at android.widget.TabHost.addTab(TabHost.java:216) 
10-01 21:24:19.641: ERROR/AndroidRuntime(21434):  at com.myapp.myapp.TreinVerkeer.setupTab(TreinVerkeer.java:131) 
10-01 21:24:19.641: ERROR/AndroidRuntime(21434):  at com.myapp.myapp.TreinVerkeer.initTabs(TreinVerkeer.java:108) 
10-01 21:24:19.641: ERROR/AndroidRuntime(21434):  at com.myapp.myapp.TreinVerkeer.onCreate(TreinVerkeer.java:62) 
10-01 21:24:19.641: ERROR/AndroidRuntime(21434):  at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1047) 
10-01 21:24:19.641: ERROR/AndroidRuntime(21434):  at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:1722) 
10-01 21:24:19.641: ERROR/AndroidRuntime(21434):  ... 11 more 
10-01 21:24:19.641: ERROR/AndroidRuntime(21434): Caused by: java.lang.RuntimeException: Unable to start activity ComponentInfo{com.myapp.myapp/com.myapp.myapp.stationstab.StationsActivity}: android.database.sqlite.SQLiteException: Can't upgrade read-only database from version 2 to 3: /data/data/com.myapp.myapp/databases/userstations 
10-01 21:24:19.641: ERROR/AndroidRuntime(21434):  at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:1768) 
10-01 21:24:19.641: ERROR/AndroidRuntime(21434):  at android.app.ActivityThread.startActivityNow(ActivityThread.java:1598) 
10-01 21:24:19.641: ERROR/AndroidRuntime(21434):  at android.app.LocalActivityManager.moveToState(LocalActivityManager.java:127) 
10-01 21:24:19.641: ERROR/AndroidRuntime(21434):  at android.app.LocalActivityManager.startActivity(LocalActivityManager.java:339) 
10-01 21:24:19.641: ERROR/AndroidRuntime(21434):  at com.myapp.myapp.stationstab.StationsActivityGroup.onCreate(StationsActivityGroup.java:38) 
10-01 21:24:19.641: ERROR/AndroidRuntime(21434):  at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1047) 
10-01 21:24:19.641: ERROR/AndroidRuntime(21434):  at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:1722) 
10-01 21:24:19.641: ERROR/AndroidRuntime(21434):  ... 22 more 
10-01 21:24:19.641: ERROR/AndroidRuntime(21434): Caused by: android.database.sqlite.SQLiteException: Can't upgrade read-only database from version 2 to 3: /data/data/com.myapp.myapp/databases/userstations 
10-01 21:24:19.641: ERROR/AndroidRuntime(21434):  at android.database.sqlite.SQLiteOpenHelper.getReadableDatabase(SQLiteOpenHelper.java:199) 
10-01 21:24:19.641: ERROR/AndroidRuntime(21434):  at com.myapp.myapp.databases.UserStationsOpenHelper.getStations(UserStationsOpenHelper.java:43) 
10-01 21:24:19.641: ERROR/AndroidRuntime(21434):  at com.myapp.myapp 

risposta

48

Si prega di vedere this pagina per la sintassi per creare una nuova colonna su un tavolo. Fondamentalmente si tratta di:

ALTER TABLE mytable ADD COLUMN mycolumn TEXT 

nel metodo ONUPGRADE, sarebbe simile a questa:

@Override 
public void onUpgrade(SQLiteDatabase db, int oldVersion, int newVersion) { 
    String upgradeQuery = "ALTER TABLE mytable ADD COLUMN mycolumn TEXT"; 
    if (oldVersion == 1 && newVersion == 2) 
     db.execSQL(upgradeQuery); 
} 
+0

Vedere la mia modifica – nhaarman

+1

Perché stai chiamando suCreate() in seguito? L'aggiornamento implica che onCreate() sia già stato chiamato (ovvero che le tabelle/db siano già state create). Il problema è dettagliato nell'eccezione (anche fino al numero di riga - Linea 25 in onCreate()). Stai tentando di creare una tabella che esiste già. – Jack

+0

Ah, ok. Ma ho la linea in cui cancello il db dopo l'aggiornamento dalla versione 1, devo chiamare l'onCreate allora? – nhaarman

2

Non ho lavorato con Android, ma SQLite fornisce 'alter table' come la maggior parte delle implementazioni di SQL fa:

SQLite alter table

+0

ALTER TABLE MyTable ADD COLUMN MyNewCol TEXT; –

6

Un approccio migliore

@Override 
public void onUpgrade(SQLiteDatabase db, int oldVersion, int newVersion) { 
    switch (oldVersion) { 
     case 1: 
      db.execSQL(SQL_MY_TABLE); 


     case 2: 
      db.execSQL("ALTER TABLE myTable ADD COLUMN myNewColumn TEXT"); 

    } 
} 

Diciamo che nel caso in cui 1, è stato aggiornato per db versione 2. Hai creato una nuova tabella ma hai dimenticato myNewColumn che vedrai nel caso 2. Ciò che verrà fatto è se cambi la versione db in 3, caso 2 verrà eseguito se aggiornamento da 2 a 3.

+0

Nella versione 3 non caso Seconda query, ridondante querys in case3 –

+0

Questo su onUpgrade che mostra quando la vecchia versione è la versione 2 quindi la nuova versione sarebbe la versione 3 e avrebbe eseguito il codice.Questo codice è corretto e funziona – Codeversed

+2

L'unico problema che vedo con questo codice è che è necessario rimuovere tutte le interruzioni dall'istruzione switch (e assicurarsi che tutti i casi siano in ordine crescente), in modo che vengano eseguiti anche tutti i casi al di sotto del caso oldVersion. – TheIT

Problemi correlati