2012-04-01 13 views
5

Questo è un compito a cui sto lavorando per familiarizzare con TDD e Rspec. Ma in qualche modo non capisco il motivo per cui il seguente test fallito:Rspec, il test per il controller di aggiornamento non funziona?

describe 'update' do 
    fixtures :movies 
    before :each do 
     @fake_movie = movies(:star_wars_movie) 
    end 
    it 'should retrieve the right movie from Movie model to update' do 
     Movie.should_receive(:find).with(@fake_movie.id.to_s).and_return(@fake_movie) 
     put :update, :id => @fake_movie.id, :movie => {:rating => @fake_movie.rating} 
    end 

    it 'should prepare the movie object available for update' do 
     put :update, :id => @fake_movie.id, :movie => {:rating => @fake_movie.rating} 
     assigns(:movie).should == @fake_movie 
    end 

    it 'should pass movie object the new attribute value to updated' do 
     fake_new_rating = 'PG-15' 
     @fake_movie.stub(:update_attributes!).with("rating" => fake_new_rating).and_return(:true) 
     put :update, :id => @fake_movie.id, :movie => {:rating => fake_new_rating} 
     @fake_movie.should_receive(:update_attributes!).with("rating" => fake_new_rating).and_return(:true) 
    end 
    end 

Il messaggio di errore ho ottenuto è:

Failures: 

    1) MoviesController update should pass movie object the new attribute value to updated 
    Failure/Error: @fake_movie.should_receive(:update_attributes!).with("rating" => fake_new_rating).and_return(:true) 
     (#<Movie:0xd39ea38>).update_attributes!({"rating"=>"PG-15"}) 
      expected: 1 time 
      received: 0 times 
    # ./spec/controllers/movies_controller_spec.rb:99:in `block (3 levels) in <top (required)>' 

Finished in 0.60219 seconds 
12 examples, 1 failure 

Failed examples: 

rspec ./spec/controllers/movies_controller_spec.rb:95 # MoviesController update should pass movie object the new attribute value to updated 

In sostanza si dice che la mia ultima linea di prova fallito @fake_movie.should_receive(:update_attributes!).with("rating" => fake_new_rating).and_return(:true), e penso non ha ricevuto la funzione chiamata "update_attributes!", ma perché?

E il codice di controllo:

def update 
    @movie = Movie.find params[:id] 
    @movie.update_attributes!(params[:movie]) 
    flash[:notice] = "#{@movie.title} was successfully updated." 
    redirect_to movie_path(@movie) 
    end 

Grazie in anticipo

risposta

3

dovrebbe essere:

it 'should pass movie object the new attribute value to updated' do 
    fake_new_rating = 'PG-15' 
    Movie.stub(:find).and_return(@fake_movie) 
    @fake_movie.should_receive(:update_attributes!).with("rating" => fake_new_rating).and_return(:true) 
    put :update, :id => @fake_movie.id, :movie => {:rating => fake_new_rating} 
end 

In caso contrario, la linea @movie = Movie.find params[:id] sarebbe interrogare contro il modello.

+2

Come buona pratica stub solo ciò che si possiede, non si possiede 'find' o' update_attributes' non si devono stub – Calin

Problemi correlati